Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): label text prop name for the react select component #6920

Conversation

sanjitbauli
Copy link
Contributor

In the storybook the prop for Label Text says helperText

Screenshot 2020-09-28 at 1 45 34 PM

Changes:
The pr will fix the prop name and change it to labelText instead of helperText which is incorrect.

@sanjitbauli sanjitbauli requested a review from a team as a code owner September 28, 2020 08:17
@netlify
Copy link

netlify bot commented Sep 28, 2020

Deploy preview for carbon-elements ready!

Built with commit cf69101

https://deploy-preview-6920--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Sep 28, 2020

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit cf69101

https://deploy-preview-6920--carbon-components-react.netlify.app

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@kodiakhq kodiakhq bot merged commit a6f39fa into carbon-design-system:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants