fix(icons-shared): generate all symbols from 32px assets #6912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit e9f8851 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit e9f8851 https://deploy-preview-6912--carbon-components-react.netlify.app |
laurenmrice
approved these changes
Sep 25, 2020
joshblack
approved these changes
Sep 25, 2020
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5758
Ref #5749
Related #5170
Related #5597
This PR updates the Sketch plugin to generate all icon size variants from the 32px assets, which addresses existing icon skew and artboard positioning issues in Sketch. A few of the icons still show some issues, but those will be addressed as part of #5749 when transparent rectangles are added to the SVG source
Changelog
Changed
Testing / Reviewing
Sync the 16/20 and 24/32 icons in sketch using the attached plugin.
carbon-elements.sketchplugin.zip
The <32px assets should look identical to the 32px assets when they are scaled down to the same size