fix(data-table): high contrast mode fixes #6873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
force-pushed
the
HCM/data-table
branch
from
8512481 to
2aa5317
Compare
tw15egan
force-pushed
the
HCM/data-table
branch
from
2aa5317 to
37ffdfe
Compare
|
Deploy preview for carbon-elements ready! Built with commit 8512481 |
|
Deploy preview for carbon-components-react ready! Built with commit 8512481 https://deploy-preview-6873--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit 5ef3c2e |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 5ef3c2e https://deploy-preview-6873--carbon-components-react.netlify.app |
joshblack
approved these changes
Sep 22, 2020
|
bump @andreancardona when you get a sec today |
andreancardona
approved these changes
Sep 22, 2020
andreancardona
added
status: ready for review 👀
and removed
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6607
Closes #6871
Adds in a specific selector for Windows HCM mode to enable proper SVG fill colors.
CSS Tricks article about accessible SVGs in HCM
Changelog
New
ButtonTextas the fill property for our SVG iconsTesting / Reviewing
On Windows, go to Settings --> Ease of Access --> High Contrast, and enable High Contrast mode. Ensure all icons are visible in all Data Table variants. Experience in HCM should be the same as a user not in HCM.