fix(TextArea): add aria-live and aria-placeholder #6819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 16758d3 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 16758d3 https://deploy-preview-6819--carbon-components-react.netlify.app |
joshblack
approved these changes
Sep 14, 2020
…5547-jaws-placeholder-invalid
|
If TextArea has |
|
@wkeese for invalid entries, yeah -- I'll open tickets for the remaining text input components. good looking out 👍🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5547
Placeholder text and invalid entry text wasn't being read by JAWS in our TextArea component. This PR makes the following changes:
aria-liveregionrole="alert"attribute to the invalid entry alert node**This is redundant, but potentially useful for certain browser/screen reader combinations (or identifying the node as an alert in the Accessibility Tree). It didn't cause any unintended consequences in my testing.
Testing / Reviewing
We should be careful that we're not breaking existing support with either NVDA or VoiceOver. In my testing this was not the case, but to be safe we should see how this reads in VoiceOver on Safari in particular 👍