Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MultiSelect): correct spacing between checkmark and item text #5773

Merged

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Apr 1, 2020

Closes #5770

related #5039

This PR corrects the spacing between the check mark and item text in all of the multiselect variants

Testing / Reviewing

Check that the multiselect and filterable multiselect appear correct

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@netlify
Copy link

netlify bot commented Apr 1, 2020

Deploy preview for carbon-elements ready!

Built with commit 020366d

https://deploy-preview-5773--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Apr 1, 2020

Deploy preview for carbon-components-react ready!

Built with commit 020366d

https://deploy-preview-5773--carbon-components-react.netlify.com

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ! thanks 👍🏻

@asudoh
Copy link
Contributor

asudoh commented Apr 2, 2020

@emyarod thinks this is ready to merge - Thanks @emyarod!

@asudoh asudoh merged commit e74beb2 into carbon-design-system:master Apr 2, 2020
@emyarod emyarod deleted the 5770-multiselect-option-spacing branch April 6, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[multi-select] checkmark icons are too close to item text in drawer
6 participants