Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(icons): add docs around icon metadata #5662

Merged

Conversation

joshblack
Copy link
Contributor

Closes #5579

Add contribution docs for icon and pictogram metadata

Changelog

New

  • Add contribution docs for icon and pictogram metadata

Changed

Removed

@joshblack joshblack requested a review from a team as a code owner March 19, 2020 16:21
@ghost ghost requested review from asudoh and tw15egan March 19, 2020 16:21
@netlify
Copy link

netlify bot commented Mar 19, 2020

Deploy preview for carbon-elements ready!

Built with commit f64b008

https://deploy-preview-5662--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Mar 19, 2020

Deploy preview for carbon-components-react ready!

Built with commit f64b008

https://deploy-preview-5662--carbon-components-react.netlify.com

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @joshblack!

chrisconnors-ibm and others added 3 commits March 21, 2020 12:37
expanded description of the renaming/removal processes
expanded the description of the renaming/removal processes
@joshblack
Copy link
Contributor Author

Thanks for the changes @chrisconnors-ibm!

Copy link
Contributor

@chrisconnors-ibm chrisconnors-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this!

@joshblack joshblack merged commit dcbcf50 into carbon-design-system:master Mar 24, 2020
@joshblack joshblack deleted the 5579-icon-metadata-docs branch March 24, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write documentation around icon metadata and expected usage
4 participants