fix(code-snippet): set correct width for feedback container in Safari #5601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-components-react ready! Built with commit ea6540e https://deploy-preview-5601--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit ea6540e |
abbeyhrt
approved these changes
Mar 11, 2020
asudoh
requested review from
a team and
laurenmrice
and removed request for
a team
dakahn
approved these changes
Mar 12, 2020
aledavila
pushed a commit
that referenced
this pull request
Mar 18, 2020
This was referenced Mar 18, 2020
renmaddox
pushed a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
renmaddox
added a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
…n Safari (carbon-design-system#5601)" This reverts commit 1c1b615.
renmaddox
added a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
…n Safari (carbon-design-system#5601)" This reverts commit 1c1b615.
renmaddox
pushed a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5595
This PR resets the copy button feedback container
box-sizingso thatmax-contentworks correctly in Safari. Not sure if this would be better in a Safari specific media query but the other browsers appear unaffectedTesting / Reviewing
Ensure that the copy button feedback has the correct width in code snippets and in the individual copy button component