fix(progress-indicator): use circle--filled icon #5585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-components-react ready! Built with commit 7b3f0c8 https://deploy-preview-5585--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 7b3f0c8 |
laurenmrice
reviewed
Mar 10, 2020
|
@laurenmrice done 👍 |
joshblack
approved these changes
Mar 10, 2020
aledavila
pushed a commit
that referenced
this pull request
Mar 18, 2020
* fix(progress-indicator): use circle--filled icon * fix(progress-indicator): change token, adjust svg margin Co-authored-by: Josh Black <[email protected]>
This was referenced Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5584
Uses the new
circle--filledicon inProgressIndicator. Also bumps theSVGicons down 1px to better align to text.Changelog
New
CircleFilled16is used for the in-progress step.Changed
1pxof top margin on svg iconsRemoved
RadioButtonChecked16and associated styles that were used to fill the iconTesting / Reviewing
Ensure the
ProgressIndicatorrenders as expected