Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): wrap icon tooltip content #5544

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

janhassel
Copy link
Member

According to the design guidelines, tooltips should wrap their content when they reach their maximum width. This was initially introduced in #2783 but seems to have been missed in the new styles when refactoring the tooltips in #2781.

Changelog

New

  • Added minimum and maximum width to tooltip styling

Testing / Reviewing

  1. Run react storybook
  2. Try out long texts in DefintionTooltip and IconTooltip

@janhassel janhassel requested a review from a team as a code owner March 5, 2020 12:45
@ghost ghost requested review from aledavila and joshblack March 5, 2020 12:45
@netlify
Copy link

netlify bot commented Mar 5, 2020

Deploy preview for carbon-components-react ready!

Built with commit d5a8dcd

https://deploy-preview-5544--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Mar 5, 2020

Deploy preview for carbon-elements ready!

Built with commit d5a8dcd

https://deploy-preview-5544--carbon-elements.netlify.com

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@joshblack joshblack merged commit 2bfcf13 into carbon-design-system:master Mar 5, 2020
joshblack added a commit to joshblack/carbon that referenced this pull request Mar 10, 2020
@janhassel janhassel deleted the tooltip-wrap branch April 2, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants