fix(toggle): change spacing to match style guide #5462
Conversation
ghost
requested review from
|
Related: #5367 It seems like it is getting the margin, even though no label is present
I think I'm leaning towards removing the spacing completely until we refactor form element spacing in v11. |
|
Deploy preview for carbon-components-react ready! Built with commit fa87fbc https://deploy-preview-5462--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit fa87fbc |
|
Deploy preview for carbon-components-react ready! Built with commit 67461e3 https://deploy-preview-5462--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 67461e3 |
Right. It seems like there's no way to write a selector for toggle switches that don't have a label.
Not a bad idea, should I refactor my PR or is there an ongoing effort to clean up the random spacing issues all throughout the codebase? |
|
No current efforts but it's been added to our planning. We can see what the other devs think in regards to removing this margin now though since you've already got the PR up. |
asudoh
requested review from
a team and
designertyler
and removed request for
a team
Changelog
Changed
Testing / Reviewing
Please validate that the wording in the style guide matches the changes that I implemented.
Please note that I checked with my UI designer colleague and we found that the toggle button in the design kit does not have a bottom margin so I decided to omit it here as well. It seems more consistent to me.