Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): add statistics icons #4824

Merged
merged 3 commits into from
Dec 9, 2019

Conversation

janhassel
Copy link
Member

@janhassel janhassel commented Dec 6, 2019

Add data type icons for ordinal and nominal data as well as an icon to describe interactions (in the context of statistics)

Changelog

New

  • Icon "ordinal"
  • Icon "nominal"
  • Icon "interactions"

Testing / Reviewing

  1. Build packages/icons
  2. Run yarn develop in /packages/icons/examples/preview
  3. Look for the icons "ordinal", "nominal" and "interactions"

@janhassel janhassel requested a review from a team as a code owner December 6, 2019 09:38
@ghost ghost requested review from dakahn and joshblack December 6, 2019 09:38
@netlify
Copy link

netlify bot commented Dec 6, 2019

Deploy preview for the-carbon-components ready!

Built with commit 0ed955c

https://deploy-preview-4824--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Dec 6, 2019

Deploy preview for carbon-elements ready!

Built with commit 0ed955c

https://deploy-preview-4824--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Dec 6, 2019

Deploy preview for carbon-components-react ready!

Built with commit 0ed955c

https://deploy-preview-4824--carbon-components-react.netlify.com

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 🎉

@joshblack joshblack merged commit dce5681 into carbon-design-system:master Dec 9, 2019
@janhassel
Copy link
Member Author

@joshblack I have a quick follow-up question: Do the framework-specific icon packages (@carbon/icons-react, @carbon/icons-vue, @carbon/icons-angular) get updated automagically or do I need to submit a PR for them as well?

Also, how can I contribute them to the master sketch libraries? (https://www.carbondesignsystem.com/resources#color-grid-and-icons)

@joshblack
Copy link
Contributor

joshblack commented Dec 10, 2019

@janhassel they should get updated automatically! If not, it definitely is an issue and let me know 😅 Should be in our next release! The same would go for our sketch library for icons as that is generated from code, as well 👍

@laurenmrice
Copy link
Member

^For our next release we will need a dev resource so we can get the new icons into the plugin so we can update the libraries.

@joshblack
Copy link
Contributor

@laurenmrice made a quick issue for this over in: #4849 for us

@janhassel
Copy link
Member Author

@joshblack Awesome, sounds good. Thanks for the info!

@janhassel janhassel deleted the data-type-icons branch April 2, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants