-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): add statistics icons #4824
feat(icons): add statistics icons #4824
Conversation
Deploy preview for the-carbon-components ready! Built with commit 0ed955c https://deploy-preview-4824--the-carbon-components.netlify.com |
Deploy preview for carbon-elements ready! Built with commit 0ed955c |
Deploy preview for carbon-components-react ready! Built with commit 0ed955c https://deploy-preview-4824--carbon-components-react.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 🎉
@joshblack I have a quick follow-up question: Do the framework-specific icon packages ( Also, how can I contribute them to the master sketch libraries? (https://www.carbondesignsystem.com/resources#color-grid-and-icons) |
@janhassel they should get updated automatically! If not, it definitely is an issue and let me know 😅 Should be in our next release! The same would go for our sketch library for icons as that is generated from code, as well 👍 |
^For our next release we will need a dev resource so we can get the new icons into the plugin so we can update the libraries. |
@laurenmrice made a quick issue for this over in: #4849 for us |
@joshblack Awesome, sounds good. Thanks for the info! |
Add data type icons for ordinal and nominal data as well as an icon to describe interactions (in the context of statistics)
Changelog
New
Testing / Reviewing
packages/icons
yarn develop
in/packages/icons/examples/preview