Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-table): update position of th cells to preserve border in Firefox #4822

Merged
merged 12 commits into from
Dec 6, 2019
Merged

fix(data-table): update position of th cells to preserve border in Firefox #4822

Changes from 8 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f08bfa6
fix(data-table): update position of th cells to preserve border
jendowns Dec 5, 2019
e86ce69
Merge branch 'master' into 2330_data-table-borders
jendowns Dec 5, 2019
b869195
Merge branch 'master' into 2330_data-table-borders
jendowns Dec 5, 2019
cfcf9bb
Merge branch 'master' into 2330_data-table-borders
jendowns Dec 5, 2019
a16955a
docs(data-table): format comment in styles
jendowns Dec 6, 2019
9c11806
docs(data-table): format comment in styles
jendowns Dec 6, 2019
3fef93b
Merge branch 'master' into 2330_data-table-borders
jendowns Dec 6, 2019
f52da91
Merge branch 'master' into 2330_data-table-borders
jendowns Dec 6, 2019
02305ce
docs(data-table): update comments about position style of table elements
jendowns Dec 6, 2019
ae51b87
Merge branch '2330_data-table-borders' of github.com:jendowns/carbon …
jendowns Dec 6, 2019
e6a5832
Merge branch 'master' into 2330_data-table-borders
asudoh Dec 6, 2019
9a412f8
Merge branch 'master' into 2330_data-table-borders
asudoh Dec 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/components/src/components/data-table/_data-table-core.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
}

.#{$prefix}--data-table th:last-of-type {
position: relative;
// Required to preserve border
position: static;
width: auto;
}

Expand Down Expand Up @@ -250,7 +251,8 @@
}

.#{$prefix}--data-table th.#{$prefix}--table-column-checkbox {
position: relative;
// Required to preserve border
position: static;
background: $ui-03;
padding: rem(12px) $spacing-03 0 $spacing-05;
width: rem(
Expand Down