fix(number-input): add check for manually entered invalid value #4817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit c89fd04 https://deploy-preview-4817--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit c89fd04 https://deploy-preview-4817--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit c89fd04 |
dakahn
approved these changes
Dec 4, 2019
joshblack
approved these changes
Dec 5, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2477
Adds check for if a user manually enters a value outside of the min/max range and displays invalidText if it does. I previously consulted with design to make sure that this was how we wanted that error to be expressed and they agreed with this approach 👍
Changelog
New
Testing / Reviewing
Go to NumberInput and type in a value above 100 and make sure the invalid text displays