fix(selectable-tile): change divs inside label to span #4745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit 38ef59c https://deploy-preview-4745--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 38ef59c |
|
Deploy preview for carbon-components-react ready! Built with commit 38ef59c https://deploy-preview-4745--carbon-components-react.netlify.com |
emyarod
reviewed
Nov 22, 2019
|
@asudoh maybe but I'm not sure what you mean by "single-selectable tile", could you clarify for me? |
|
@emyarod yeah it does! I'll make that change. 👍 |
joshblack
approved these changes
Nov 22, 2019
|
@abbeyhrt Would you try searching for |
|
Thanks @abbeyhrt for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3369
According to the issue, it is invalid HTML markup to have a
divinside of alabelso I changed them tospanChangelog
Changed
div->spanTesting / Reviewing
Make sure the SelectableTile looks the same and is still functioning properly