-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pagination): input wrapper alignment closes #4733 #4740
fix(pagination): input wrapper alignment closes #4733 #4740
Conversation
Deploy preview for carbon-elements ready! Built with commit 9a78369 |
Deploy preview for carbon-components-react ready! Built with commit 9a78369 https://deploy-preview-4740--carbon-components-react.netlify.com |
Deploy preview for the-carbon-components ready! Built with commit 9a78369 https://deploy-preview-4740--the-carbon-components.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh my VM for IE11 is expired so will need to refresh. Tested though in latest:
- Chrome
- Safari
- Firefox
- Edge for Mac
@joshblack here's ie11: |
@vpicone lol love the browser version info in the screenshot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also don't have access to IE11 but checked in the same browsers and the IE11 screenshot and it looks good to me! Would we need design approval on something like this?
Just verified with IE11 👍 |
Regression was likely due to IE fixes, test in all browsers