fix(composed-modal): moves aria-label from close icon to close button #4727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4707
This PR moves the
aria-label
that was on theClose20
icon to the closebutton
removing this DAP violation. Also changes the default value oficonDescription
to just 'Close'.Changelog
Changed
aria-label
Testing / Reviewing
Run DAP on the ComposedModal and make sure you do not see the above violation.