-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add build step to generate react docgen metadata #4662
chore: add build step to generate react docgen metadata #4662
Conversation
Deploy preview for the-carbon-components ready! Built with commit c253887 https://deploy-preview-4662--the-carbon-components.netlify.com |
Deploy preview for carbon-components-react ready! Built with commit c253887 https://deploy-preview-4662--carbon-components-react.netlify.com |
Deploy preview for carbon-elements ready! Built with commit c253887 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM basically - Would you fix the CI? Thanks @vpicone!
…generate-react-docgen-info
…n into generate-react-docgen-info
@asudoh fixed thanks! @jnm2377 @joshblack holler if you have any questions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, docgen
directory and react-docgen.json
are generated
Use
build/docgen
to generate areact-docgen.json
file (published)
just wondering, does react-docgen.json
need to be separate from build/docgen
if they're both ignored? or does the json file need to be at the package root?
@emyarod "publish" here refers to what get's pushed to npm. The build directory is ignored when publishing, the It doesn't need to be at the package root per-se, but it makes it easy to find/import. It's also where we put metadata files historically (icons, pictograms). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thanks for confirming
Closes #4635
New:
docgen
babel-plugin-react-docgen
build/docgen
(not published)build/docgen
to generate areact-docgen.json
file (published)Testing:
yarn workspace carbon-components-react build
react-docgen.json
file with docgen data in the react package.