-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: form spacing #4576
fix: form spacing #4576
Conversation
Deploy preview for the-carbon-components ready! Built with commit c97cce7 https://deploy-preview-4576--the-carbon-components.netlify.com |
Deploy preview for carbon-elements failed. Built with commit c97cce7 https://app.netlify.com/sites/carbon-elements/deploys/5dc2243359201300083a33bf |
Deploy preview for carbon-components-react ready! Built with commit c97cce7 https://deploy-preview-4576--carbon-components-react.netlify.com |
@@ -29,6 +29,7 @@ | |||
// `flex-direction: row` | |||
flex: 1 1 auto; | |||
align-items: flex-start; | |||
margin-bottom: $carbon--spacing-06; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would adding this to bx--form-item
unexpected add margin for folks using this control? Might be good to offer it by default, but might catch folks off guard if we add this layout potentially
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I think this is part of a discussion that's been on hold since the v10 effort began
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If dev thinks its ok to update without breaking people then it good to me.
Coming back to this, looks like we can't update it without causing a breaking change for certain users 😞Went ahead and added a Just wanted to say thanks so much for your time and effort here, really appreciate it 🙏 Sorry that things took so long and ended up the way that they did 😞 |
@joshblack no need to apologize! Happy to (continue to) help where I can 👍 . Thanks for following up 😄 |
Closes #2343
Changelog
Changed
margin-bottom
toform--form-item
using the$carbon--spacing-06
following the Form Style Guidemargin-bottom
onform--fieldset
to$carbon--spacing-06
for consistencyTesting / Reviewing
Storybook before (small snippet):
Storybook after (small snippet):