Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toggle): update colors #4038

Merged
merged 3 commits into from
Sep 20, 2019

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Sep 19, 2019

Fixes #3614.

Changelog

Changed

Updated following according to the new spec:

  • Circle colors in off state.
  • Focus outline styles.

Testing / Reviewing

Testing should make sure toggle is not broken.

@netlify
Copy link

netlify bot commented Sep 19, 2019

Deploy preview for the-carbon-components ready!

Built with commit 15e8973

https://deploy-preview-4038--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Sep 19, 2019

Deploy preview for carbon-components-react ready!

Built with commit 15e8973

https://deploy-preview-4038--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Sep 19, 2019

Deploy preview for carbon-elements ready!

Built with commit 15e8973

https://deploy-preview-4038--carbon-elements.netlify.com

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, token changes and focus styles appear to match the new spec now

image

image

Copy link
Contributor

@vpicone vpicone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment these box-shadows or pull off into a variable or something? Hard to tell what's happening just by looking at it.

box-shadow: 0 0 0 1px transparent, 0 0 0 1px transparent,
        0 0 0 3px transparent;

@asudoh
Copy link
Contributor Author

asudoh commented Sep 19, 2019

@vpicone Updated.

Copy link
Contributor

@shixiedesign shixiedesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Exactly as spec'ed. Thank you!

@shixiedesign shixiedesign merged commit 9ac1eef into carbon-design-system:master Sep 20, 2019
@asudoh asudoh deleted the toggle-colors branch September 20, 2019 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Off state of toggle (and small toggle) lacks 3:1 contrast with adjacent color (background)
5 participants