-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(toggle): update colors #4038
fix(toggle): update colors #4038
Conversation
Deploy preview for the-carbon-components ready! Built with commit 15e8973 https://deploy-preview-4038--the-carbon-components.netlify.com |
Deploy preview for carbon-components-react ready! Built with commit 15e8973 https://deploy-preview-4038--carbon-components-react.netlify.com |
Deploy preview for carbon-elements ready! Built with commit 15e8973 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment these box-shadows or pull off into a variable or something? Hard to tell what's happening just by looking at it.
box-shadow: 0 0 0 1px transparent, 0 0 0 1px transparent,
0 0 0 3px transparent;
@vpicone Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Exactly as spec'ed. Thank you!
Fixes #3614.
Changelog
Changed
Updated following according to the new spec:
Testing / Reviewing
Testing should make sure toggle is not broken.