-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css-reset): apply box-sizing reset to all descendants #3884
Conversation
Deploy preview for the-carbon-components ready! Built with commit b27db43 https://deploy-preview-3884--the-carbon-components.netlify.com |
Deploy preview for carbon-elements failed. Built with commit a198d5f https://app.netlify.com/sites/carbon-elements/deploys/5d698dfbdfebf10008f33d6f |
Deploy preview for carbon-components-react failed. Built with commit a198d5f https://app.netlify.com/sites/carbon-components-react/deploys/5d698dfa49e0ed00070b0456 |
Deploy preview for carbon-elements ready! Built with commit b27db43 |
Deploy preview for carbon-components-react failed. Built with commit b27db43 https://app.netlify.com/sites/carbon-components-react/deploys/5d6e7d68af7d150009e4082f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, just one note
Closes #3786
Changelog
Changed
box-sizing
reset to all descendants, not just direct children