Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css-reset): apply box-sizing reset to all descendants #3884

Merged
merged 4 commits into from
Sep 3, 2019
Merged

fix(css-reset): apply box-sizing reset to all descendants #3884

merged 4 commits into from
Sep 3, 2019

Conversation

jendowns
Copy link
Contributor

Closes #3786

Changelog

Changed

  • now applies box-sizing reset to all descendants, not just direct children

@netlify
Copy link

netlify bot commented Aug 30, 2019

Deploy preview for the-carbon-components ready!

Built with commit b27db43

https://deploy-preview-3884--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Aug 30, 2019

Deploy preview for carbon-elements failed.

Built with commit a198d5f

https://app.netlify.com/sites/carbon-elements/deploys/5d698dfbdfebf10008f33d6f

@netlify
Copy link

netlify bot commented Aug 30, 2019

Deploy preview for carbon-components-react failed.

Built with commit a198d5f

https://app.netlify.com/sites/carbon-components-react/deploys/5d698dfa49e0ed00070b0456

@netlify
Copy link

netlify bot commented Aug 30, 2019

Deploy preview for carbon-elements ready!

Built with commit b27db43

https://deploy-preview-3884--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Aug 30, 2019

Deploy preview for carbon-components-react failed.

Built with commit b27db43

https://app.netlify.com/sites/carbon-components-react/deploys/5d6e7d68af7d150009e4082f

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just one note

packages/components/src/globals/scss/_css--reset.scss Outdated Show resolved Hide resolved
@emyarod emyarod merged commit 784e4e8 into carbon-design-system:master Sep 3, 2019
@jnm2377 jnm2377 mentioned this pull request Sep 4, 2019
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS Reset mixin only applies box-sizing rule to immediate children
4 participants