fix(Dropdown, ComboBox): adds listener to open/close menu on enter #3862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit f17071b https://deploy-preview-3862--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit d45fac4 https://deploy-preview-3862--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit d45fac4 |
ghost
requested review from
|
Deploy preview for carbon-components-react ready! Built with commit f17071b https://deploy-preview-3862--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit f17071b |
tw15egan
reviewed
Aug 29, 2019
| @@ -12,6 +12,8 @@ import React from 'react'; | |||
| import { settings } from 'carbon-components'; | |||
| import { WarningFilled16 } from '@carbon/icons-react'; | |||
| import ListBox, { PropTypes as ListBoxPropTypes } from '../ListBox'; | |||
| import { match } from '../../internal/keyboard/match'; | |||
| import * as keys from '../../internal/keyboard/keys'; | |||
There was a problem hiding this comment.
Can we simplify this to be import { match, keys } from '../../internal/keyboard';?
There was a problem hiding this comment.
Yeah for sure, made the change!
tw15egan
reviewed
Aug 29, 2019
| @@ -12,6 +12,8 @@ import React from 'react'; | |||
| import { settings } from 'carbon-components'; | |||
| import { WarningFilled16 } from '@carbon/icons-react'; | |||
| import ListBox, { PropTypes as ListBoxPropTypes } from '../ListBox'; | |||
| import { match } from '../../internal/keyboard/match'; | |||
| import * as keys from '../../internal/keyboard/keys'; | |||
tw15egan
approved these changes
Aug 29, 2019
… into fix-dropdown-enter-doesnt-collapse-list
…hub.com/abbeyhrt/my-carbon-fork into fix-dropdown-enter-doesnt-collapse-list
joshblack
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2823
Components using Downshift, like Dropdown and ComboBox, were not opening on enter, this adds
toggleMenufrom Downshift to toggle the menu whenisOpenchanges.*Note: this problem also affects MultiSelect, since it uses Downshift but is more complicated to fix. I've made an issue (#3861) and will work on a solution for that separately.
Changelog
Changed
ListBox.Fieldto toggleMenu on enterTesting / Reviewing
Go to ComboBox and Dropdown, tab into them and make sure they toggle open/close with Enter press.