fix(TableToolbarSearch): support back-tab #3836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the issue with `<TableToolbarSearch>` that happens when the `<input>` in it has focus and user performs back-tab gesture (Shift-Tab key). In such scenario (in before-change version), the root element of `<TableToolbarSearch>` (`<div class="bx--toolbar-search-container-expandable">`) gets focus given it has `tabindex="0"`, and the `onFocus()` handler of the element attempts to send focus back to the `<input>` no matter what. This change also fixes the following found in the debugging effort: * An issue where `id` of `<Search>` in `<TableToolbarSearch>` is regenerated for every render * Issues focus on `<input>` happening: * For every render, regardless of change in expanded state * Even for controlled change in expanded state (without user gesture) Fixes carbon-design-system#3762.
|
Deploy preview for the-carbon-components ready! Built with commit bc0ab54 https://deploy-preview-3836--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit bc0ab54 |
|
Deploy preview for carbon-components-react ready! Built with commit bc0ab54 https://deploy-preview-3836--carbon-components-react.netlify.com |
jnm2377
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the issue with
<TableToolbarSearch>that happens when the<input>in it has focus and user performs back-tab gesture (Shift-Tab key).In such scenario (in before-change version), the root element of
<TableToolbarSearch>(<div class="bx--toolbar-search-container-expandable">) gets focus given it hastabindex="0", and theonFocus()handler of the element attempts to send focus back to the<input>no matter what.This change also fixes the following found in the debugging effort:
idof<Search>in<TableToolbarSearch>is regenerated for every render<input>happening:Fixes #3762.
Changelog
New
<input>code from runningChanged
tabindexof the outer container of<TableToolbarSearch>, so it's focusable only when it's collapsedRemoved
<TableToolbarSearch>given the<input>in it handles thatTesting / Reviewing
Testing should make sure
<TableToolbarSearch>is not broken.