-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tabs): update token values #3828
Conversation
Deploy preview for the-carbon-components ready! Built with commit 3e273d1 https://deploy-preview-3828--the-carbon-components.netlify.com |
Deploy preview for carbon-elements ready! Built with commit 3e273d1 |
Deploy preview for carbon-components-react failed. Built with commit 3e273d1 https://app.netlify.com/sites/carbon-components-react/deploys/5d6425a209de3e000a49a412 |
Deploy preview for the-carbon-components ready! Built with commit 2f2b2c4 https://deploy-preview-3828--the-carbon-components.netlify.com |
Deploy preview for carbon-components-react ready! Built with commit 2f2b2c4 https://deploy-preview-3828--carbon-components-react.netlify.com |
Deploy preview for carbon-elements ready! Built with commit 2f2b2c4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change - Thanks @tw15egan!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Closes #3827
Updates
Tab
theme values to use the correct token values.Changelog
Changed
$tab-underline-color
,$tab-underline-color-hover
,$tab-text-disabled
, and$tab-underline-disabled
valuesTesting / Reviewing
Check that disabled
Tab
looks correct