Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): update token values #3828

Merged
merged 4 commits into from
Aug 27, 2019

Conversation

tw15egan
Copy link
Collaborator

Closes #3827

Updates Tab theme values to use the correct token values.

Changelog

Changed

  • $tab-underline-color, $tab-underline-color-hover, $tab-text-disabled, and $tab-underline-disabled values

Testing / Reviewing

Check that disabled Tab looks correct

@netlify
Copy link

netlify bot commented Aug 26, 2019

Deploy preview for the-carbon-components ready!

Built with commit 3e273d1

https://deploy-preview-3828--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Aug 26, 2019

Deploy preview for carbon-elements ready!

Built with commit 3e273d1

https://deploy-preview-3828--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Aug 26, 2019

Deploy preview for carbon-components-react failed.

Built with commit 3e273d1

https://app.netlify.com/sites/carbon-components-react/deploys/5d6425a209de3e000a49a412

@netlify
Copy link

netlify bot commented Aug 26, 2019

Deploy preview for the-carbon-components ready!

Built with commit 2f2b2c4

https://deploy-preview-3828--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Aug 26, 2019

Deploy preview for carbon-components-react ready!

Built with commit 2f2b2c4

https://deploy-preview-3828--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Aug 26, 2019

Deploy preview for carbon-elements ready!

Built with commit 2f2b2c4

https://deploy-preview-3828--carbon-elements.netlify.com

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change - Thanks @tw15egan!

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@tw15egan tw15egan merged commit f12dfca into carbon-design-system:master Aug 27, 2019
@jnm2377 jnm2377 mentioned this pull request Sep 4, 2019
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carbon Tab component does not use tokens listed on Carbon website and cannot be themed correctly
4 participants