fix(breadcrumb): terminating slash based on current page existence #3750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to example/story code, where they use "with trailing slash" mode for ones without current page, and "without trailing slash" mode for ones with current page, so the current page existence can be commnunicated by the existence of the trailing slash. Fixes carbon-design-system#3625.
|
Deploy preview for the-carbon-components ready! Built with commit ea74f72 https://deploy-preview-3750--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit ea74f72 |
|
Deploy preview for carbon-components-react ready! Built with commit ea74f72 https://deploy-preview-3750--carbon-components-react.netlify.com |
joshblack
approved these changes
Aug 16, 2019
aagonzales
approved these changes
Aug 16, 2019
|
Follow up: could we remove the underline on hover for the current page and still be compliant? |
This change does the following things for the current page link: * Remove `text-decoration` from its `:hover` state * Use default cursor
@aagonzales Done! Also addressed a comment from @shixiedesign in #3625, by changing the mouse cursor for "current page" link. |
aagonzales
approved these changes
Aug 19, 2019
shixiedesign
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to example/story code, where they use "with trailing slash" mode for ones without current page, and "without trailing slash" mode for ones with current page, so the current page existence can be commnunicated by the existence of the trailing slash.
Fixes #3625.
Changelog
Changed
Testing / Reviewing
Testing should make sure breadcrumbs demo/story are not broken.