fix(type): add default type feature flag #3742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit 02139bf https://deploy-preview-3742--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 02139bf |
|
Deploy preview for carbon-components-react ready! Built with commit 02139bf https://deploy-preview-3742--carbon-components-react.netlify.com |
asudoh
approved these changes
Aug 15, 2019
| @@ -199,3 +199,9 @@ | |||
| @include carbon--icons; | |||
| } | |||
| } | |||
|
|
|||
| @include exports('css--default-type') { | |||
| @if variable-exists(css--default-type) == false or $css--default-type==true { | |||
There was a problem hiding this comment.
Style nit - Probably spaces around ==?
alisonjoseph
approved these changes
Aug 16, 2019
emyarod
reviewed
Aug 16, 2019
|
@alisonjoseph yes, the strong declaration was in the css reset before this change, so I left it in there. @emyarod will update the snapshots 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #3648
Changed