fix(ComboBox): fix fully controlled story and delete test story #18680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18680 +/- ##
=======================================
Coverage 84.97% 84.97%
=======================================
Files 408 408
Lines 14543 14543
Branches 4765 4715 -50
=======================================
Hits 12358 12358
- Misses 2023 2024 +1
+ Partials 162 161 -1 ☔ View full report in Codecov by Sentry. |
|
If someone could assign #17192 to me, that would be appreciated. |
Gururajj77
approved these changes
Feb 25, 2025
2nikhiltom
approved these changes
Feb 25, 2025
Merged
via the queue into
carbon-design-system:main
with commit Feb 25, 2025
d4a071a
38 checks passed
|
Hey there! v11.77.0 was just released that references this issue/PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17192
Fixed the fully controlled
ComboBoxstory and deleted the test story.Changelog
Changed
ComboBoxstory.Removed
ComboBoxtest story that was added in fix: use initialSelectedItem only on initial render in ComboBox #18602.Testing / Reviewing
cd packages/react yarn storybook