-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update FilterableMultiSelect onMenuChange behavior #18606
fix: update FilterableMultiSelect onMenuChange behavior #18606
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18606 +/- ##
=======================================
Coverage 84.91% 84.92%
=======================================
Files 408 408
Lines 14551 14557 +6
Branches 4765 4772 +7
=======================================
+ Hits 12356 12362 +6
+ Misses 2033 2032 -1
- Partials 162 163 +1 ☔ View full report in Codecov by Sentry. |
Hey @adamalston , could you write more about what are the changes you did and how it affects the component's behaviour?? |
I've updated the logic so that:
The tests reflect these scenarios. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
packages/react/src/components/MultiSelect/__tests__/FilterableMultiSelect-test.js
Outdated
Show resolved
Hide resolved
I see the security scan is failing. I guess it didn't like me merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
c2cc7de
Hey there! v11.77.0 was just released that references this issue/PR. |
Closes #18270
Updated
FilterableMultiSelect
'sonMenuChange
behavior.Changelog
Changed
FilterableMultiSelect
'sonMenuChange
behavior.Testing / Reviewing
yarn test packages/react/src/components/MultiSelect/__tests__/FilterableMultiSelect-test.js