fix: add anchor element attribute types to Button #18598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18598 +/- ##
=======================================
Coverage 84.02% 84.02%
=======================================
Files 408 408
Lines 14494 14494
Branches 4726 4730 +4
=======================================
Hits 12178 12178
+ Misses 2150 2149 -1
- Partials 166 167 +1 ☔ View full report in Codecov by Sentry. |
riddhybansal
approved these changes
Feb 17, 2025
alisonjoseph
approved these changes
Feb 18, 2025
Merged
via the queue into
carbon-design-system:main
with commit Feb 18, 2025
73c1439
37 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18573
Added anchor element (
<a>) attribute types toButton.Changelog
New
<a>) attribute types toButton.Testing / Reviewing
Add these props to
Buttons in TypeScript files and check for errors.