-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: center alligned ghost icon button #18503
fix: center alligned ghost icon button #18503
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18503 +/- ##
=======================================
Coverage 84.92% 84.92%
=======================================
Files 408 408
Lines 14501 14501
Branches 4729 4699 -30
=======================================
Hits 12315 12315
+ Misses 2026 2025 -1
- Partials 160 161 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Icon button is broken for some other sizes and variant as well for both react and web components . Here is the issue created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, Thanks for the changes Riddhi!
Hey I approved the PR and then saw its failing the Percy, can you please check why it's updating the snapshot. Thanks! |
62b5c1e
Closes #18420
Fix ghost button icon alignment in icon-only variant
Changelog
Changed
Testing / Reviewing
Steps to verify: