-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stackblitz to components #18433
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18433 +/- ##
=======================================
Coverage 83.98% 83.98%
=======================================
Files 408 408
Lines 14501 14501
Branches 4699 4679 -20
=======================================
Hits 12178 12178
- Misses 2155 2156 +1
+ Partials 168 167 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Awesome work!
The content of this pull request will be made available as part of our next release. For the full schedule of upcoming releases, check out our Release Radar page. |
This PR #18433 was created to add the "Open in StackBlitz" feature. During the implementation of this PR, several issues were identified, including StackBlitz malfunctions, layout problems in StackBlitz and the Overview page, and the need for code updates. These issues were not addressed in this PR as they are outside its scope. Below are the open issues for the identified problems:
Lauren also opened another one after reviewing the PR:
|
Closes #18474
First wave of components docs update to added "Open in Stackblitz".
Changelog
Changed
Canvas
to some components, so "Open in Stackblitz" should be displayed in storybook.mdx
file to some components.Testing / Reviewing