Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stackblitz to components #18433

Merged
merged 19 commits into from
Feb 21, 2025
Merged

feat: add stackblitz to components #18433

merged 19 commits into from
Feb 21, 2025

Conversation

heloiselui
Copy link
Contributor

@heloiselui heloiselui commented Jan 24, 2025

Closes #18474

First wave of components docs update to added "Open in Stackblitz".

Changelog

Changed

  • Added Canvas to some components, so "Open in Stackblitz" should be displayed in storybook.
  • Updated and created mdx file to some components.

Testing / Reviewing

  • CI should pass
  • Stories should work as expected
  • Try to open a few stories on Stackblitz
  • Need refinement and more tests

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit fb501d0
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67b49bdec9d84d0008247380
😎 Deploy Preview https://deploy-preview-18433--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit fb501d0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67b49bde8ecdbe0008e98d50
😎 Deploy Preview https://deploy-preview-18433--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit fb501d0
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67b49bde4f57000008fac1c3
😎 Deploy Preview https://deploy-preview-18433--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (73c1439) to head (fb501d0).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18433   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         408      408           
  Lines       14501    14501           
  Branches     4699     4679   -20     
=======================================
  Hits        12178    12178           
- Misses       2155     2156    +1     
+ Partials      168      167    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heloiselui heloiselui requested review from a team and kiran-ravindra-ibm and removed request for a team January 31, 2025 12:15
@laurenmrice laurenmrice requested review from laurenmrice and removed request for kiran-ravindra-ibm January 31, 2025 16:49
@heloiselui heloiselui marked this pull request as ready for review January 31, 2025 18:10
@heloiselui heloiselui requested a review from a team as a code owner January 31, 2025 18:11
@guidari guidari self-requested a review February 10, 2025 14:44
@heloiselui heloiselui requested review from a team as code owners February 12, 2025 13:31
Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Awesome work!

@heloiselui heloiselui added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit 95fb301 Feb 21, 2025
37 checks passed
@heloiselui heloiselui deleted the 18344-stackblitz branch February 21, 2025 10:29
Copy link
Contributor

The content of this pull request will be made available as part of our next release. For the full schedule of upcoming releases, check out our Release Radar page.

@heloiselui
Copy link
Contributor Author

This PR #18433 was created to add the "Open in StackBlitz" feature.

During the implementation of this PR, several issues were identified, including StackBlitz malfunctions, layout problems in StackBlitz and the Overview page, and the need for code updates. These issues were not addressed in this PR as they are outside its scope.

Below are the open issues for the identified problems:

  • #18538 – Feels like it could be a big issue. It might be worth breaking it down into sub-issues to make it more manageable.
  • #18661 – More related to layout and interaction of some components in StackBlitz.
  • #18652 – Focuses on styling issues, like background colors, grid structures, and theme inconsistencies.
  • #18546 – Covers more structural updates to the code.

Lauren also opened another one after reviewing the PR:

  • #18657 - Some visual issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open in Stackblitz: Wave 1
4 participants