fix(18204): remove redundant aria-label in inline mode for AILabel component #18407
+30
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18407 +/- ##
=======================================
Coverage 84.17% 84.17%
=======================================
Files 408 408
Lines 14435 14436 +1
Branches 4690 4661 -29
=======================================
+ Hits 12150 12151 +1
Misses 2120 2120
Partials 165 165 ☔ View full report in Codecov by Sentry. |
ariellalgilmore
approved these changes
Jan 24, 2025
|
The content of this pull request will be made available as part of our next release. For the full schedule of upcoming releases, check out our Release Radar page. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18204
For
kind="inline"in AILabel, aria-label duplicated visible text content (see phill's comment on the issue)This PR sets empty aria-label when kind='inline' to let native text content serve as accessible name:
label={kind === 'inline' ? '' : ariaLabelText}Changelog
Removed
makes aria-label empty when kind='inline'
Added test cases to validate the cases
updated tests in Tabs
Testing / Reviewing
visit expandable AILabel storybook in deploy preview
run Accessibility Checker with 3.1.75 and later versions and verify "a11y Violation - Accessible name does not match or contain the visible label text " is not seen