fix: Fixed OverflowMenu nested bug
#17861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
annawen1
approved these changes
Oct 23, 2024
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17861 +/- ##
=======================================
Coverage 80.14% 80.14%
=======================================
Files 406 406
Lines 14030 14030
Branches 4391 4343 -48
=======================================
Hits 11245 11245
- Misses 2618 2619 +1
+ Partials 167 166 -1 ☔ View full report in Codecov by Sentry. |
|
this was incorrectly closed by the revert PR |
tay1orjones
approved these changes
Oct 24, 2024
|
Hey there! v11.69.0 was just released that references this issue/PR. |
irfadkp
pushed a commit
to irfadkp/carbon
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17781
The addition of the
enable-v12-dynamic-floating-styleto OverflowMenu causes a bug when it is an OverflowMenu Nested. By removing theuseFeatureFlagfrom this line it works fine.So the solution I found it was to disable the
enable-v12-dynamic-floating-stylefor the Nested stories, looking something like the screen shot:The ideia is to show that the Nested stories do not support
enable-v12-dynamic-floating-style.I'll open a new issue to track why it isn't working.
Testing / Reviewing