fix(Tabs): reset active index to selected index for manual activation #17831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
emyarod
changed the title
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
emyarod
force-pushed
the
17591-fix/manual-tabs-selected-index-onblur
branch
from
26f0261 to
c28c40e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17831 +/- ##
==========================================
- Coverage 80.14% 80.14% -0.01%
==========================================
Files 406 406
Lines 14029 14039 +10
Branches 4391 4395 +4
==========================================
+ Hits 11243 11251 +8
- Misses 2620 2621 +1
- Partials 166 167 +1 ☔ View full report in Codecov by Sentry. |
kennylam
approved these changes
Oct 23, 2024
Merged
via the queue into
carbon-design-system:main
with commit Oct 23, 2024
5f4f0a6
39 of 40 checks passed
|
Hey there! v11.69.0 was just released that references this issue/PR. |
irfadkp
pushed a commit
to irfadkp/carbon
that referenced
this pull request
Oct 24, 2024
…carbon-design-system#17831) * refactor(Tabs): rename internal vars * fix(Tabs): reset active index to selected index for manual activation * test(Tabs): test manual activation blur handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17591
This PR adds blur handlers to the tabs and vertical tabs components to reset the active tab index to the selected tab index.
Changelog
New
handleBlurmethodsTesting / Reviewing