test(fluid-components): increase coverage and fix skeleton components #17823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17823 +/- ##
==========================================
+ Coverage 80.35% 80.54% +0.19%
==========================================
Files 406 406
Lines 14041 14038 -3
Branches 4395 4395
==========================================
+ Hits 11282 11307 +25
+ Misses 2593 2563 -30
- Partials 166 168 +2 ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
annawen1
approved these changes
Oct 25, 2024
Merged
via the queue into
carbon-design-system:main
with commit Oct 29, 2024
b7c523a
40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17478
Closes #17487
Closes #17486
Closes #17514
Closes #17515
Closes #17518
Closes #17511
Closes #17519
Increase test coverage to 100% for FluidTextAreaSkeleton, FluidSelectSkeleton, FluidComboBoxSkeleton, FluidPasswordInput, FluidTextInputSkeleton, FluidDropdownSkeleton, FluidMultiSelect
Changelog
New
-increased test coverages to 100%
Changed
classNameis in the outsideTesting / Reviewing
confirm skeleton updates with animation
confirm tests are at 100%