fix: web-components - specify js extensions for icon imports #17818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17818 +/- ##
=======================================
Coverage 80.15% 80.15%
=======================================
Files 406 406
Lines 14011 14011
Branches 4332 4332
=======================================
Hits 11231 11231
Misses 2614 2614
Partials 166 166 ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
carbon-design-system:main
with commit Oct 21, 2024
203c3b9
26 of 27 checks passed
annawen1
added a commit
to annawen1/carbon
that referenced
this pull request
Oct 22, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
* chore: rename ai slug to ai label * chore: rename to ai-label * chore: rename slug example to ai-label * chore: add ai label to form group stories * chore: rename handle slug slot change methods * chore: all stories shifted * fix: fix radio-button with ai-label * fix: modal ai-label styles * chore: rename test files to ai-label * chore: add space between AI and Label in docs * chore: undo changes to tearsheet and side-panel * chore: keep slug component as deprecated * chore: restore readme * fix: specify js extensions for icon imports (#17818) * chore: add extensions to icons in stories * fix: show actions for playground and datatable sort * fix: catch both slug and ai-label in event handlers
|
Hey there! v11.69.0 was just released that references this issue/PR. |
irfadkp
pushed a commit
to irfadkp/carbon
that referenced
this pull request
Oct 24, 2024
…ign-system#17739) * chore: rename ai slug to ai label * chore: rename to ai-label * chore: rename slug example to ai-label * chore: add ai label to form group stories * chore: rename handle slug slot change methods * chore: all stories shifted * fix: fix radio-button with ai-label * fix: modal ai-label styles * chore: rename test files to ai-label * chore: add space between AI and Label in docs * chore: undo changes to tearsheet and side-panel * chore: keep slug component as deprecated * chore: restore readme * fix: specify js extensions for icon imports (carbon-design-system#17818) * chore: add extensions to icons in stories * fix: show actions for playground and datatable sort * fix: catch both slug and ai-label in event handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17813
Closes #17650
For users importing the
@carbon/web-componentspackage and using webpack, there is an error appearing - mandating the specification of the extension in the icon imports.Changelog
Changed
.jsextensions to all the icon imports in the@carbon/web-componentscomponent files.jsextension to thespread.jsfile that is included in all exported icon filesTesting / Reviewing
npm install & npm run buildthere are no errors appearing