Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ibm-common): add ibm-common.js to web components storybook #17769

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

jeffchew
Copy link
Member

Noticed that the web component storybook was not instrumented with ibm-common.js, so adding that here.

Changelog

Changed

  • add ibm-common.js and DDO object to storybook manager head (web components)

@jeffchew jeffchew requested a review from a team as a code owner October 16, 2024 16:10
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 226f7ee
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/670fe57be4c50800089b43c2
😎 Deploy Preview https://deploy-preview-17769--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 226f7ee
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/670fe57bb2c76d0008066dac
😎 Deploy Preview https://deploy-preview-17769--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.33%. Comparing base (eea76a2) to head (226f7ee).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17769   +/-   ##
=======================================
  Coverage   79.33%   79.33%           
=======================================
  Files         406      406           
  Lines       14019    14019           
  Branches     4384     4384           
=======================================
  Hits        11122    11122           
  Misses       2732     2732           
  Partials      165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into carbon-design-system:main with commit cf80652 Oct 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants