Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(structured-list): increase coverage #17705

Conversation

ariellalgilmore
Copy link
Member

Closes #17508
Closes #17509

Increase coverage for Structured list and Structured list skeleton

Changelog

New

  • added structuredList skeleton

Changed

  • updated StructuredList imports and added a test to check clicking on a selection row

Testing / Reviewing

Make sure tests are passing

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit d92fd0c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6706d703820ab7000880df5b
😎 Deploy Preview https://deploy-preview-17705--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d92fd0c
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6706d703de7a9200080154b9
😎 Deploy Preview https://deploy-preview-17705--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.98%. Comparing base (9d1822c) to head (d92fd0c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17705      +/-   ##
==========================================
+ Coverage   78.33%   78.98%   +0.64%     
==========================================
  Files         408      408              
  Lines       14015    14015              
  Branches     4324     4376      +52     
==========================================
+ Hits        10979    11070      +91     
+ Misses       2868     2778      -90     
+ Partials      168      167       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ariellalgilmore ariellalgilmore marked this pull request as ready for review October 9, 2024 20:25
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner October 9, 2024 20:25
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-10-10 at 8 27 39 AM

@kennylam kennylam added this pull request to the merge queue Oct 10, 2024
Merged via the queue into carbon-design-system:main with commit 33fd9e7 Oct 10, 2024
23 checks passed
@ariellalgilmore ariellalgilmore deleted the test/structured-list-increase-coverage branch October 10, 2024 15:38
annawen1 pushed a commit to annawen1/carbon that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase StructuredList.Skeleton unit test coverage Increase StructuredList unit test coverage
3 participants