test: increase test coverage to 100% for Tag #17614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17614 +/- ##
==========================================
+ Coverage 77.19% 77.26% +0.06%
==========================================
Files 409 409
Lines 14025 14025
Branches 4355 4355
==========================================
+ Hits 10827 10836 +9
+ Misses 3029 3019 -10
- Partials 169 170 +1 ☔ View full report in Codecov by Sentry. |
…m/carbon into 17503_Tag_TestCoverage
kennylam
reviewed
Oct 2, 2024
2nikhiltom
added
status: one more review 👀
and removed
status: ready for review 👀
labels
alisonjoseph
approved these changes
Oct 9, 2024
alisonjoseph
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit Oct 9, 2024
b44a218
36 checks passed
annawen1
pushed a commit
to annawen1/carbon
that referenced
this pull request
Oct 11, 2024
) * test: increase test coverage to 100% for Tag * refactor: spyOn updated * refactor: removed unused import --------- Co-authored-by: Preeti Bansal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17503
Increase test coverage to 100% for Tag component
Changelog
Added new test cases
Testing / Reviewing
Test coverage should increase
Verify that test makes sense