test(chat-button-toggle-skeleton): increase coverage #17440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17440 +/- ##
==========================================
+ Coverage 76.82% 76.98% +0.15%
==========================================
Files 408 408
Lines 13973 13973
Branches 4341 4288 -53
==========================================
+ Hits 10735 10757 +22
+ Misses 3064 3043 -21
+ Partials 174 173 -1 ☔ View full report in Codecov by Sentry. |
ariellalgilmore
changed the title
ariellalgilmore
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
carbon-design-system:main
with commit Oct 9, 2024
c5ce4eb
36 checks passed
ariellalgilmore
deleted the
chore/chat-button-toggle-skeleton-test-updates
branch
|
Hey there! v11.68.0 was just released that references this issue/PR. |
annawen1
pushed a commit
to annawen1/carbon
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17431
Closes #17432
Closes #17429
Add test coverage for Chat Button, Chat Button Skeleton, and Toggle Skeleton
Changelog
New
Testing / Reviewing
confirm testing passes
codecov should be 100% for these files