Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add disabled attribute back to FormGroup #17058

Merged

Conversation

wkeese
Copy link
Contributor

@wkeese wkeese commented Jul 29, 2024

Closes #17057

Add disabled attribute back to FormGroup.
Fixes regression from Carbon 11.

Changelog

New

  • {{new thing}}

Changed

  • FormGroup has disabled attribute again.

Removed

  • {{removed thing}}

Testing / Reviewing

@wkeese wkeese requested a review from a team as a code owner July 29, 2024 08:28
@wkeese wkeese requested review from alisonjoseph and guidari July 29, 2024 08:28
Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4677c4c
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66a791501a27d60009c537f8
😎 Deploy Preview https://deploy-preview-17058--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4677c4c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66a79150a212250008065e0f
😎 Deploy Preview https://deploy-preview-17058--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@riddhybansal
Copy link
Contributor

riddhybansal commented Jul 29, 2024

LGTM , JUST need to update snapshots to pass cli.

@wkeese wkeese requested a review from a team as a code owner July 29, 2024 12:55
@wkeese
Copy link
Contributor Author

wkeese commented Jul 29, 2024

Thanks, I pushed that change now.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The story looks good, though it only includes a few components.

It's possible there are other components that may be styled off of a disabled prop/class and not styled off of :disabled. In that case the child component would need disabled, otherwise it wouldn't get proper disabled styling when this is placed on the wrapping FormGroup.

No need to hold up the merge though. If we uncover some components with this issue we can fix them at that time.

@tay1orjones tay1orjones added this pull request to the merge queue Jul 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2024
@riddhybansal riddhybansal added this pull request to the merge queue Jul 30, 2024
Merged via the queue into carbon-design-system:main with commit 50e88bc Jul 30, 2024
22 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.63.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: FormGroup lost disabled attribute in Carbon 11
4 participants