-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add disabled attribute back to FormGroup #17058
fix: add disabled attribute back to FormGroup #17058
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LGTM , JUST need to update snapshots to pass cli. |
Thanks, I pushed that change now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The story looks good, though it only includes a few components.
It's possible there are other components that may be styled off of a disabled
prop/class and not styled off of :disabled
. In that case the child component would need disabled
, otherwise it wouldn't get proper disabled styling when this is placed on the wrapping FormGroup
.
No need to hold up the merge though. If we uncover some components with this issue we can fix them at that time.
50e88bc
Hey there! v11.63.0 was just released that references this issue/PR. |
Closes #17057
Add disabled attribute back to FormGroup.
Fixes regression from Carbon 11.
Changelog
New
Changed
Removed
Testing / Reviewing