Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: closing of calendar without selecting end date #16653

Merged

Conversation

riddhybansal
Copy link
Contributor

Closes #16473

Fixed closing of calendar without selecting end date

Changelog

Removed

  • Removed fp.close() from the rangePlugin as it was not doing anything.

Testing / Reviewing

See if the calendar in range mode does not close without selecting end date.

@riddhybansal riddhybansal requested a review from a team as a code owner June 4, 2024 13:38
Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ea7010c
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/665f18e9a514e70008c59485
😎 Deploy Preview https://deploy-preview-16653--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit ea7010c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/665f18e934cb7c000863ae12
😎 Deploy Preview https://deploy-preview-16653--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9a9151a
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/665f1906f4f33e000869085b
😎 Deploy Preview https://deploy-preview-16653--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 9a9151a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/665f19062216350008953265
😎 Deploy Preview https://deploy-preview-16653--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Gururajj77 Gururajj77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@riddhybansal riddhybansal added this pull request to the merge queue Jun 4, 2024
Merged via the queue into carbon-design-system:main with commit a2a3657 Jun 4, 2024
21 checks passed
@riddhybansal riddhybansal deleted the Datepicker_Range_issue branch June 4, 2024 19:16
@carbon-automation
Copy link
Contributor

Hey there! v11.59.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DatePicker Range has unintended behavior when selecting dates
3 participants