Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overview page meta issue #16587

Merged

Conversation

riddhybansal
Copy link
Contributor

Closes #16488

Overview page meta issue

Changelog

Removed

  • Meta tag from TextInput overview.mdx

Testing / Reviewing

Go to TextInput story -> Overview It should work as intended there should not be any bug.

@riddhybansal riddhybansal requested a review from a team as a code owner May 28, 2024 13:37
Copy link

netlify bot commented May 28, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cd03d46
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/665625b13238ea000893c2c0
😎 Deploy Preview https://deploy-preview-16587--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 28, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit cd03d46
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/665625b136d4c100080ed6da
😎 Deploy Preview https://deploy-preview-16587--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think that will solve the error, since it doesn't seen to be necessary to insert.

@riddhybansal riddhybansal added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@riddhybansal riddhybansal added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
@alisonjoseph alisonjoseph added this pull request to the merge queue May 29, 2024
Merged via the queue into carbon-design-system:main with commit 6e857da May 29, 2024
21 checks passed
dkaushik95 pushed a commit to dkaushik95/carbon that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextInput overview page is broken in storybook
4 participants