-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(16294): update interface to include target prop in SwitcherItem type #16295
Merged
alisonjoseph
merged 4 commits into
carbon-design-system:main
from
ahmedsemih:TS_error_target_prop
May 22, 2024
Merged
fix(16294): update interface to include target prop in SwitcherItem type #16295
alisonjoseph
merged 4 commits into
carbon-design-system:main
from
ahmedsemih:TS_error_target_prop
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All contributors have signed the DCO. |
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ahmedsemih
changed the title
fix(16294): update interface to include target prop in switcheritem type
fix(16294): update interface to include target prop in SwitcherItem type
May 1, 2024
2nikhiltom
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, Thanks for the contribution.
guidari
approved these changes
May 10, 2024
tay1orjones
approved these changes
May 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 21, 2024
Merged
via the queue into
carbon-design-system:main
with commit May 22, 2024
cfb682c
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16294
Added optional "target" prop to
BaseSwitcherItemProps
for specify where to open the link.Changelog
New
Added target prop to
BaseSwitcherItemProps
Testing / Reviewing
When used as above, the Typescript compiler was giving the error “Property ‘target’ does not exist on type ....” before I fixed it. Now there is no such error, it behaves like a normal anchor tag target property.