Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table-toolbar-menu): update styles to use layer-02 #15982

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Mar 15, 2024

Closes #15970

Changelog

New

  • Add menuOptionsClass to TableToolbarMenu to ensure this prop is still configurable now that it's no longer passed through ...rest

Changed

  • Fix TableToolbarMenu styling to use the intended layer styling

Testing / Reviewing

Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit adeff01
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65f8d00ec3e8d800082d035b
😎 Deploy Preview https://deploy-preview-15982--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toolbar looks good to me, just needs a snapshot update 😅

@tay1orjones tay1orjones requested a review from a team as a code owner March 18, 2024 23:36
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated snapshots, looks good!

@andreancardona andreancardona added this pull request to the merge queue Mar 18, 2024
Merged via the queue into carbon-design-system:main with commit 6d409a7 Mar 19, 2024
20 checks passed
preetibansalui pushed a commit to tay1orjones/carbon that referenced this pull request Apr 24, 2024
…-system#15982)

* fix(table-toolbar-menu): update styles to use layer-02

* chore: updates snapshots

---------

Co-authored-by: Andrea N. Cardona <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: menus opening from the data table tool bar are incorrect token
3 participants