docs(Slug): add dev docs to Slug overview #15812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@tw15egan this is excellent. What about the other components? Are there docs explaining how to pass in a Slug component into the slug prop? |
|
@mattrosno I can add that. Would it make sense to keep it all in this overview, or should I add it to the examples folder? I’ll add some DataTable docs as well |
|
@tw15egan at minimum, maybe something in all 4 Overviews, even if 3 of them just point you to the first that includes all documentation. 
No strong preference here besides having something mentioned in all Overviews. |
|
@mattrosno updated |
mattrosno
requested changes
Feb 26, 2024
mattrosno
reviewed
Feb 26, 2024
This was referenced Feb 26, 2024
|
@mattrosno fixed 👍🏻 |
mattrosno
approved these changes
Feb 28, 2024
tay1orjones
approved these changes
Feb 28, 2024
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit Feb 28, 2024
50c634e
20 checks passed
|
Hey there! v11.52.0 was just released that references this issue/PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15784
Adds in documentation regarding the usage of the
Slugcomponent and its propsChangelog
New
Slugcomponent and a few of its propsChanged
Testing / Reviewing
Ensure the spelling/grammar is correct and the content makes sense. Is there anything else we are missing?