-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Modal): update Modal styles to phase 2 AI spec #15727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aagonzales
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🎉
tw15egan
force-pushed
the
ai-modal-phase-2
branch
from
February 13, 2024 15:13
b120fa2
to
9436bac
Compare
alisonjoseph
approved these changes
Feb 13, 2024
alisonjoseph
added
status: one more review 👀
and removed
status: ready for review 👀
status: visual review 🔍
labels
Feb 13, 2024
tw15egan
force-pushed
the
ai-modal-phase-2
branch
from
February 14, 2024 18:10
541e397
to
6385cac
Compare
guidari
approved these changes
Feb 14, 2024
Merged
via the queue into
carbon-design-system:main
with commit Feb 14, 2024
de4793c
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15709
Updates
Modal
to use the new phase 2 AI specsChangelog
New
$ai-overlay
token addedChanged
Modal
styles have been updated to phase 2 specTesting / Reviewing
Ensure
Modal
andComposedModal
underSlug --> Examples
matches the spec and there are no regressions