fix: convert menubutton to typescript, and do other menu typescript cleanup. #15447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@wkeese Hey Bill, is there a way you can take a look at these merge conflicts? Thank you! |
|
Looks like the conversion was already mainly handled by #15361 (cc @mattborghi). The main thing left in my PR is |
wkeese
changed the title
This builds on #15361 to do a few more menu-related Typescript updates: * MenuButton: Convert to Typescript. * MenuContext: Specify type for context. There’s contradictory evidence though about whether payload is mandatory or optional. * Menu: Minor cleanup including specifying that when x and y are arrays, the arrays contain exactly two numbers. * MenuItem: Convert some “any” types into actual types, including converting MenuItemRadioGroup to a generic. Also the same cleanup as above about x and y as arrays. Ignore spacing diffs. * useAttachedMenu() - Convert to Typescript. I had to add @ts-ignore to some of the PropTypes declarations for reasons I don't understand. I'm not too worried about it since PropTypes declarations are essentially deprecated. Also, I know the doc said not to convert internal files to Typescript but it didn’t seem feasible to do this conversion without useAttachedMenu.js and MenuContext.ts having the right types, and it didn’t seem feasible for them to have the right types without converting them to Typescript. Menu, MenuButton and MenuItem were left out of the list on #12513 but I assume they should be updated too. Actually, I need MenuButton and MenuItem to be updated before I can upgrade to Carbon 11. Other notes: I had to add @ts-ignore to the PropTypes declarations for reasons I don't understand. I'm not too worried about it since PropTypes declarations are essentially deprecated. Also, I know the doc said not to convert internal files to Typescript but it didn’t seem feasible to do this conversion without useAttachedMenu.js and MenuContext.ts having the right types, and it didn’t seem feasible for them to have the right types without converting them to Typescript.
|
@tay1orjones, @andreancardona - I fixed the merge conflicts. This is the second time it's happened, so hopefully this PR can be merged soon. The MenuButton conversion to Typescript changed the indentation, so git diff and git merge are useless. It doesn't even realize that index.tsx is just index.js renamed. Even though I used |
tw15egan
added
status: ready for review 👀
status: one more review 👀
and removed
status: merge conflict 🚫
labels
guidari
approved these changes
Feb 16, 2024
Merged
via the queue into
carbon-design-system:main
with commit Feb 16, 2024
00dc60f
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #15361 to do a few more menu-related Typescript updates:
MenuButton: Convert to Typescript.MenuContext: Specify type for context. There’s contradictory evidence though about whether payload is mandatory or optional.Menu: Minor cleanup including specifying that whenxandyare arrays, the arrays contain exactly two numbers.MenuItem: Convert some “any” types into actual types, including converting MenuItemRadioGroup to a generic. Also the same cleanup as above about x and y as arrays. Ignore spacing diffs.useAttachedMenu()- Convert to Typescript.I had to add
@ts-ignoreto some of thePropTypesdeclarations for reasons I don't understand. I'm not too worried about it sincePropTypesdeclarations are essentially deprecated.Also, I know the doc said not to convert internal files to Typescript but it didn’t seem feasible to do this conversion without useAttachedMenu.js and MenuContext.ts having the right types, and it didn’t seem feasible for them to have the right types without converting them to Typescript.