feat: Type pagination #15399
feat: Type pagination #15399
Conversation
Tresau
force-pushed
the
type-pagination
branch
from
9966f0f to
0d615c5
Compare
|
|
||
| export interface PaginationPageSize { | ||
| text: string; | ||
| value: string; |
There was a problem hiding this comment.
Completely appreciate this is still a draft, but just to flag in the case it's helpful, based on this (and its display in the docs);
carbon/packages/react/src/components/Pagination/Pagination.tsx
Lines 508 to 516 in d30eb7c
This might need to be a number
| value: string; | |
| value: number; |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
| pageSizes: PropTypes.oneOfType([ | ||
| PropTypes.arrayOf(PropTypes.number), | ||
| PropTypes.arrayOf(PropTypes.number.isRequired), | ||
| PropTypes.arrayOf( | ||
| PropTypes.shape({ | ||
| text: PropTypes.text, | ||
| value: PropTypes.number, | ||
| }) | ||
| text: PropTypes.string.isRequired, | ||
| value: PropTypes.number.isRequired, | ||
| }).isRequired |
There was a problem hiding this comment.
Since I updated text -> string, and needed to add some isRequired to fields to prevent typescript errors, I needed to update the public api snapshot accordingly. Not sure if this will cause this to needed to go out in a major change.
There was a problem hiding this comment.
Cool. I don't think it will a problem!
|
Hopefully this can be merged soon, AFAIK it's the last Carbon problem preventing us from upgrading a bunch of our code to Carbon 11. |
| pageSizes: PropTypes.oneOfType([ | ||
| PropTypes.arrayOf(PropTypes.number), | ||
| PropTypes.arrayOf(PropTypes.number.isRequired), | ||
| PropTypes.arrayOf( | ||
| PropTypes.shape({ | ||
| text: PropTypes.text, | ||
| value: PropTypes.number, | ||
| }) | ||
| text: PropTypes.string.isRequired, | ||
| value: PropTypes.number.isRequired, | ||
| }).isRequired |
There was a problem hiding this comment.
Cool. I don't think it will a problem!
9346f3e
* feat: add types to Pagination * refactor: update pageSizes proptype to correctly match interface * test: update public snapshot since proptypes changed
Closes #13566
adds TypeScript types to Pagination and PaginationSkeleton. Depends on #15057
Changelog
Changed
Removed
Testing / Reviewing
Verify that unit test run, verify that storybook works as intended