Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Slug): ensure all necessary styles are imported #15345

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Dec 7, 2023

Closes #15341

Ensures Slug renders as expected when only pulling in the Slug styles

Changelog

New

  • Added toggletip import to Slug styles so all styles are imported

Testing / Reviewing

Comment all styles in packages/react/.storybook/styles.scss and add the following:

@use '@carbon/react/scss/reset';
@use '@carbon/react/scss/fonts';
@use '@carbon/react/scss/components/slug';

Go to the experimental slug story and ensure it renders as expected.

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit b9d69a8
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6571d9a87e561a00072cbd3c
😎 Deploy Preview https://deploy-preview-15345--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added this pull request to the merge queue Dec 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 7, 2023
@tw15egan tw15egan added this pull request to the merge queue Dec 7, 2023
Merged via the queue into carbon-design-system:main with commit 7e8d352 Dec 7, 2023
21 checks passed
@tw15egan tw15egan deleted the slug-styles-fix branch December 7, 2023 17:38
danoro96 pushed a commit to danoro96/carbon that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Slug styles don't contain all the necessary dependent styles/modules
3 participants