fix(column): remove percentage character only if present

[janhassel]

Closes #15311

See issue for details. Currently, if the user passes md="8" it will generate the following css classname: cds--md:col-span-. Passing in lg="16" will result to cds--lg:col-span-1.

Changelog

Changed

• Instead of always removing the last character, only remove a percentage sign if one exists

Testing / Reviewing

• See linked issue's reproduction

[netlify]

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	95aa577
🔍 Latest deploy log	https://app.netlify.com/sites/v11-carbon-react/deploys/65737296a3b6fe00088c0df0
😎 Deploy Preview	https://deploy-preview-15312--v11-carbon-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[tay1orjones]

Thanks for the fix!

I'm personally still on the fence about these percentage classes. 😅 We only kind of "soft-support" them - I think there's only classes for 25%, 50%, 75%, 100%? It was a new idea added in the initial CSSGrid implementation that IIRC we didn't have previously with FlexGrid. Anyway, I'm glad someone is using them, and appreciate you submitting this fix!

[janhassel]

@tay1orjones I am actually not using the percentage classes in any designs and did not know they exist. 😅 I came across this when I was prototyping without TypeScript for a change and did not remember that the type should be number instead of string.